Skip to content

Refactor Chest UI and Fix Drag Interactions#21

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
chest-inventory-fixes-13619490328120730100
Draft

Refactor Chest UI and Fix Drag Interactions#21
google-labs-jules[bot] wants to merge 1 commit intomainfrom
chest-inventory-fixes-13619490328120730100

Conversation

@google-labs-jules
Copy link
Contributor

This change addresses several user requests regarding the Chest component and Drag-and-Drop system.

Key improvements:

  1. Inventory UI: The inventory is no longer a full-screen modal (except visually on the map). It now appears as a "bubble" pointing to the chest icon on the bottom right.
  2. Interaction: The blocking backdrop is removed on the 'Records' page, allowing users to drag items from the chest directly to the "Add Trip" button or other UI elements without obstruction.
  3. Bug Fixes:
    • Fixed a bug where the drop zone highlight would remain "stuck" (green) if the drag ended while hovering.
    • Fixed text selection interfering with dragging by globally disabling user-select during drag.
  4. Styling: Changed the Chest's drop zone highlight from the default green fill to a Minecraft-style white border.

PR created automatically by Jules for task 13619490328120730100 started by @OsakaLOOP

- Refactor Chest inventory to use a bottom-right anchored bubble UI with a tail.
- Restrict full-screen backdrop to 'map' tab only; enable interaction on other tabs.
- Implement click-outside logic to close the Chest inventory on non-map tabs.
- Fix 'stuck highlight' bug in DropZone by resetting `isOver` state on drag end.
- Globally disable text selection (`user-select: none`) during drag operations.
- Update Chest DropZone highlight style to a white border to match Minecraft aesthetic.
- Pass `activeTab` prop to Chest component for conditional backdrop rendering.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants